Mae/groupsvoteroute #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this passes group_id and max_capacity from groups 
|
pabloj2001
requested changes
Nov 18, 2023
api/optimeet/groups/urls.py
Outdated
| path("<int:group_id>/recs", views.get_recommendation) | ||
| path("<int:group_id>/recs", views.get_recommendation), | ||
| path("<int:group_id>/votes", views.votes, name='votes'), | ||
| path("<int:group_id>/votescreate", views.create_vote, name='create_vote'), |
There was a problem hiding this comment.
Instead of making a new route for getting or creating, we want to leverage HTTP verbs like GET and POST. We can reuse the same /votes route and have GET requests go to one function and POST requests go to another.
|
updated: |
pabloj2001
previously requested changes
Nov 20, 2023
api/optimeet/groups/models.py
Outdated
| class Votes(models.Model): | ||
| group_id = models.ForeignKey(Group, related_name='group_votes', on_delete=models.CASCADE) | ||
| user_id = models.CharField(max_length=64, blank=True) | ||
| results_of_voted = models.CharField(max_length=64, blank=True) |
There was a problem hiding this comment.
How would results_of_voted be used? Since this is a single vote that a particular user is making in a group we wouldn't keep track of multiple votes. Also remember what we're voting for: recommendations, so we should add the recommendation id this vote is for as a foreign key.
pabloj2001
requested review from
itsPedro231
and removed request for
itsPedro231
marissa-anj
dismissed
pabloj2001’s stale review
Fixed votes view issue fixes issue
pabloj2001
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.