Wider t0 shift allowed. Robust image autorange and histogram. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks David. In order to unblock you from further modifications, I will make you a maintainer of this repository. Then, you won't have to go through pull requests |
|
Thanks Laurent!
David
…________________________________
From: Laurent P. René de Cotret ***@***.***>
Sent: August 15, 2024 4:30 PM
To: LaurentRDC/iris-ued ***@***.***>
Cc: David Cai ***@***.***>; Author ***@***.***>
Subject: Re: [LaurentRDC/iris-ued] Wider t0 shift allowed. Robust image autorange and histogram. (PR #28)
You don't often get email from ***@***.*** Learn why this is important<https://aka.ms/LearnAboutSenderIdentification>
Awesome, thanks David.
In order to unblock you from further modifications, I will make you a maintainer of this repository. Then, you won't have to go through pull requests
—
Reply to this email directly, view it on GitHub<#28 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOJS4DAOPWVDMPCYXW32VD3ZRUFVTAVCNFSM6AAAAABMSWOFUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJSGE4DENBUGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
I forgot to release these changes! They are part of iris-ued 5.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I increased the range of adjustment for the time zero shift spin box since now the instrument scans between 0 and 2000 ps.
The histogram widget autoranges to the absolute min/max when a dataset is loaded. If the detector has a few saturated pixels, the histogram autoscales and autolevels to some obscurely high values. I used the 1% and 98% percentiles in hope that this is more robust.