Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration converter #155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Configuration converter #155

wants to merge 1 commit into from

Conversation

Sajidali1031
Copy link
Contributor

Want to add main_NERSC_ILDG_Converter

dbollweg
dbollweg requested changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@dbollweg dbollweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your Cmake target is commented out, please uncomment and check that it compiles, than we can merge

@clarkedavida
Copy link
Collaborator

why are we adding a new executable when we already have a configuration converter here: https://github.com/LatticeQCD/SIMULATeQCD/blob/main/src/applications/main_configConverter.cpp

it also already does nersc to ILDG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbollweg dbollweg dbollweg requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sajidali1031 @clarkedavida @dbollweg