Merge pull request #31 from moroshko/cleanup

Don't check component type (it's broken in dev)

src/components/Flex.test.js

@@ -14,9 +14,7 @@ describe("Flex", () => {
 
   it("with testId", () => {
     const { container } = render(
-      <Flex gap="2" testId="my-flex">
-        Content goes here
-      </Flex>
+      <Flex testId="my-flex">Content goes here</Flex>
     );
 
     expect(container.firstChild).toHaveAttribute("data-testid", "my-flex");

src/components/Footer.js

@@ -153,10 +153,16 @@ Header.propTypes = {
 };
 
 function LegalLinks({ children, testId }) {
-  const links = React.Children.toArray(children).filter(
-    // Ignore all children that aren't a Link
-    child => child.type === Link
-  );
+  const links = React.Children.toArray(children);
+
+  /*
+    This stopped working at some point, so filtering here would result in [].
+  
+    .filter(
+      // Ignore all children that aren't a Link
+      child => child.type === Link
+    );
+  */
 
   return (
     <Flex gap="3 4" wrap placeItems="top center" testId={testId}>

src/components/List.js

@@ -67,10 +67,15 @@ function List(props) {
     margin: responsiveMargin
   });
   const ListComponent = type === "unordered" ? "ul" : "ol";
-  const items = React.Children.toArray(children).filter(
-    // Ignore all children that aren't List.Item
-    child => child.type === Item
-  );
+  const items = React.Children.toArray(children);
+  /*
+    This stopped working at some point, so filtering here would result in [].
+  
+    .filter(
+      // Ignore all children that aren't List.Item
+      child => child.type === Item
+    );
+  */
 
   let list = (
     <ListComponent

src/components/List.test.js

@@ -76,21 +76,6 @@ describe("List", () => {
     getByText("Last Item");
   });
 
-  it("ignores children that are not List.Item", () => {
-    const { queryByText } = render(
-      <List>
-        <p>Hello</p>
-        <List.Item>First Item</List.Item>
-        <List.Item>Second Item</List.Item>
-        <div>World</div>
-        <List.Item>Third Item</List.Item>
-      </List>
-    );
-
-    expect(queryByText("Hello")).not.toBeInTheDocument();
-    expect(queryByText("World")).not.toBeInTheDocument();
-  });
-
   it("with testId", () => {
     const { container } = render(
       <List testId="my-list">

src/components/Stepper.js

@@ -100,10 +100,17 @@ function Stepper(_props) {
   const props = { ...DEFAULT_PROPS, ..._props };
   const { completed, children, testId } = props;
   const theme = useTheme();
-  const steps = React.Children.toArray(children).filter(
-    // Ignore all children that aren't Step.Item
-    child => child.type === Item
-  );
+  const steps = React.Children.toArray(children);
+
+  /*
+    This stopped working at some point, so filtering here would result in [].
+  
+    .filter(
+      // Ignore all children that aren't Step.Item
+      child => child.type === Item
+    );
+  */
+
   const currentStepIndex = steps.findIndex(step => step.props.current === true);
 
   return (

website/src/components/ComponentPreview.js

@@ -32,7 +32,7 @@ function LivePreviewWrapper({ containerRef, highlightedComponents, children }) {
     <div
       css={{
         position: "relative",
-        minHeight: "100vh"
+        height: "100vh"
       }}
       ref={containerRef}
     >