Add eslint-plugin-testing-library and eslint-plugin-jest-dom

LatitudeFinancialOSS · May 10, 2020 · 455fec2 · 455fec2 · vercel · May 10, 2020
1 parent 5d6c751
commit 455fec2
Show file tree

Hide file tree

Showing 4 changed files with 32 additions and 3 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -3,9 +3,12 @@
   "extends": [
     "eslint:recommended",
     "plugin:react/recommended",
-    "plugin:jest/recommended"
+    "plugin:jest/recommended",
+    "plugin:testing-library/recommended",
+    "plugin:testing-library/react",
+    "plugin:jest-dom/recommended"
   ],
-  "plugins": ["react-hooks", "jest"],
+  "plugins": ["react-hooks", "jest", "testing-library", "jest-dom"],
   "rules": {
     "no-unused-vars": [
       "error",

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -58,8 +58,10 @@
     "cross-env": "7.0.2",
     "eslint": "7.0.0",
     "eslint-plugin-jest": "23.10.0",
+    "eslint-plugin-jest-dom": "^2.1.0",
     "eslint-plugin-react": "7.19.0",
     "eslint-plugin-react-hooks": "4.0.0",
+    "eslint-plugin-testing-library": "^3.1.2",
     "husky": "4.2.5",
     "jest": "26.0.1",
     "mq-polyfill": "1.1.8",

diff --git a/src/components/Checkbox.test.js b/src/components/Checkbox.test.js
@@ -31,7 +31,7 @@ describe("Checkbox", () => {
       "id",
       checkboxContainer.getAttribute("aria-labelledby")
     );
-    expect(checkboxContainer).toHaveAttribute("aria-checked", "false");
+    expect(checkboxContainer).not.toBeChecked();
 
     const checkboxInput = checkboxContainer.querySelector(
       'input[type="checkbox"]'