Skip to content

Commit

Permalink
fix: remove access-less helpers and add a maplint (ParadiseSS13#27462)
Browse files Browse the repository at this point in the history
  • Loading branch information
warriorstar-orion authored Nov 27, 2024
1 parent b33be74 commit 324f145
Show file tree
Hide file tree
Showing 3 changed files with 76 additions and 5 deletions.
6 changes: 3 additions & 3 deletions _maps/map_files/shuttles/emergency_lance.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -472,9 +472,6 @@
/obj/structure/window/reinforced{
dir = 1
},
/obj/effect/mapping_helpers/airlock/windoor/access/all/command{
dir = 4
},
/obj/machinery/door/window/reinforced/normal{
name = "Last Resort";
dir = 4
Expand All @@ -487,6 +484,9 @@
pixel_y = -6
},
/obj/item/gun/energy/gun/mini,
/obj/effect/mapping_helpers/airlock/windoor/access/all/command/general{
dir = 4
},
/turf/simulated/floor/plasteel/dark,
/area/shuttle/escape)
"vk" = (
Expand Down
4 changes: 2 additions & 2 deletions _maps/map_files/stations/emeraldstation.dmm
Original file line number Diff line number Diff line change
Expand Up @@ -22718,8 +22718,8 @@
},
/obj/machinery/atmospherics/pipe/simple/hidden/supply,
/obj/machinery/atmospherics/pipe/simple/hidden/scrubbers,
/obj/effect/mapping_helpers/airlock/access/any/command,
/obj/machinery/door/firedoor,
/obj/effect/mapping_helpers/airlock/access/any/command/general,
/turf/simulated/floor/plasteel{
icon_state = "dark"
},
Expand Down Expand Up @@ -55406,7 +55406,7 @@
d2 = 2;
icon_state = "1-2"
},
/obj/effect/mapping_helpers/airlock/windoor/access/all/command,
/obj/effect/mapping_helpers/airlock/windoor/access/all/command/general,
/turf/simulated/floor/plasteel,
/area/station/command/bridge)
"klt" = (
Expand Down
71 changes: 71 additions & 0 deletions tools/maplint/lints/generic_access_helpers.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
help: 'These access helpers are only organizational and do not provide any access. Use one of the appropriate subtypes.'
=/obj/effect/mapping_helpers/airlock/windoor/access/all:
banned: true
=/obj/effect/mapping_helpers/airlock/windoor/access/all/command:
banned: true
=/obj/effect/mapping_helpers/airlock/windoor/access/all/engineering:
banned: true
=/obj/effect/mapping_helpers/airlock/windoor/access/all/medical:
banned: true
=/obj/effect/mapping_helpers/airlock/windoor/access/all/science:
banned: true
=/obj/effect/mapping_helpers/airlock/windoor/access/all/security:
banned: true
=/obj/effect/mapping_helpers/airlock/windoor/access/all/service:
banned: true
=/obj/effect/mapping_helpers/airlock/windoor/access/all/supply:
banned: true
=/obj/effect/mapping_helpers/airlock/windoor/access/any:
banned: true
=/obj/effect/mapping_helpers/airlock/windoor/access/any/command:
banned: true
=/obj/effect/mapping_helpers/airlock/windoor/access/any/engineering:
banned: true
=/obj/effect/mapping_helpers/airlock/windoor/access/any/medical:
banned: true
=/obj/effect/mapping_helpers/airlock/windoor/access/any/science:
banned: true
=/obj/effect/mapping_helpers/airlock/windoor/access/any/security:
banned: true
=/obj/effect/mapping_helpers/airlock/windoor/access/any/service:
banned: true
=/obj/effect/mapping_helpers/airlock/windoor/access/any/supply:
banned: true
=/obj/effect/mapping_helpers/airlock/access/all:
banned: true
=/obj/effect/mapping_helpers/airlock/access/all/centcomm:
banned: true
=/obj/effect/mapping_helpers/airlock/access/all/command:
banned: true
=/obj/effect/mapping_helpers/airlock/access/all/engineering:
banned: true
=/obj/effect/mapping_helpers/airlock/access/all/medical:
banned: true
=/obj/effect/mapping_helpers/airlock/access/all/ruins:
banned: true
=/obj/effect/mapping_helpers/airlock/access/all/science:
banned: true
=/obj/effect/mapping_helpers/airlock/access/all/security:
banned: true
=/obj/effect/mapping_helpers/airlock/access/all/service:
banned: true
=/obj/effect/mapping_helpers/airlock/access/all/shuttles:
banned: true
=/obj/effect/mapping_helpers/airlock/access/all/supply:
banned: true
=/obj/effect/mapping_helpers/airlock/access/any:
banned: true
=/obj/effect/mapping_helpers/airlock/access/any/command:
banned: true
=/obj/effect/mapping_helpers/airlock/access/any/engineering:
banned: true
=/obj/effect/mapping_helpers/airlock/access/any/medical:
banned: true
=/obj/effect/mapping_helpers/airlock/access/any/science:
banned: true
=/obj/effect/mapping_helpers/airlock/access/any/security:
banned: true
=/obj/effect/mapping_helpers/airlock/access/any/service:
banned: true
=/obj/effect/mapping_helpers/airlock/access/any/supply:
banned: true

0 comments on commit 324f145

Please sign in to comment.