Fixed memory leaks in parser #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jpnock
reviewed
Mar 10, 2024
| @@ -11,6 +11,7 @@ | |||
| extern FILE *yyin; | |||
| int yylex(void); | |||
| void yyerror(const char *); | |||
| int yylex_destroy(void); | |||
There was a problem hiding this comment.
Suggested change
| int yylex_destroy(void); | |
| int yylex_destroy(void); |
There was a problem hiding this comment.
Looks fine in ide, github indentation just looks weird
There was a problem hiding this comment.
You are using a tab. The rest of this block is using 4 spaces.
| @@ -7,6 +7,7 @@ | |||
| extern FILE *yyin; | |||
| int yylex(void); | |||
| void yyerror(const char *); | |||
| int yylex_destroy(void); | |||
There was a problem hiding this comment.
Suggested change
| int yylex_destroy(void); | |
| int yylex_destroy(void); |
Fiwo735
approved these changes
Mar 11, 2024
|
On a very side note, should the changes above also benefit lab 2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #22, created a separate PR to fix the memory issues outlined in #21.