-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further test improvements (2) #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng and failing tests
If colours seem to cause an issue on user's systems then this can be reverted.
Fiwo735
approved these changes
Feb 21, 2024
Hmm this seems like a bad merge, give me a sec |
Yeah just noticed something weird going on |
Fixed. EDIT: for some reason it looks like it's only carried over the code changes and not the docs changes from #9 I will cherry pick these. |
Fiwo735
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @Fiwo735 (#9)
From @Jpnock (#17)
Pass
would lead to a test being marked as passing inshort
mode)coloarma
, I've tested on both Linux, Mac and WSL and colours seem to work fine without this dependency. Did we see a user reported bug for this? If so, it's fine to just revert 4f42126.