Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further test improvements (2) #18

Merged
merged 11 commits into from
Feb 21, 2024
Merged

Further test improvements (2) #18

merged 11 commits into from
Feb 21, 2024

Conversation

Jpnock
Copy link
Collaborator

@Jpnock Jpnock commented Feb 21, 2024

From @Fiwo735 (#9)

  • Improved Python testing, making it the default and recommended testing option.
  • Removed duplicated test case (same functionality as _example)
  • Updated AST diagram to the new version

From @Jpnock (#17)

  • Refactors the test script in an attempt to reduce cohesion
  • Ignores coverage and pycache files in git
  • Attempts to always output a valid JUnit XML file
  • Escapes XML attributes and values to prevent test results corrupting the XML output
  • Unifies the two ways of counting passes and fails into one method for consistency (previously group names, folders, test names or test logs containing the phrase Pass would lead to a test being marked as passing in short mode)
  • As for coloarma, I've tested on both Linux, Mac and WSL and colours seem to work fine without this dependency. Did we see a user reported bug for this? If so, it's fine to just revert 4f42126.
  • Bumps the script version number

@Jpnock Jpnock requested a review from Fiwo735 February 21, 2024 03:57
@Jpnock
Copy link
Collaborator Author

Jpnock commented Feb 21, 2024

Hmm this seems like a bad merge, give me a sec

@Fiwo735
Copy link
Collaborator

Fiwo735 commented Feb 21, 2024

Hmm this seems like a bad merge, give me a sec

Yeah just noticed something weird going on

@Jpnock
Copy link
Collaborator Author

Jpnock commented Feb 21, 2024

Fixed.

EDIT: for some reason it looks like it's only carried over the code changes and not the docs changes from #9 I will cherry pick these.

@Fiwo735 Fiwo735 merged commit 78bb9de into main Feb 21, 2024
2 checks passed
@Fiwo735 Fiwo735 deleted the further_test_improvements branch March 16, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants