Fix tests (#185)

LaihoE · Jun 28, 2024 · d09e467 · d09e467
1 parent 8eedf40
commit d09e467
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 32 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -63,4 +63,4 @@ jobs:
           pip install pytest maturin patchelf
 
           maturin develop
-          pytest
+          python3 tests/signature_tests.py
diff --git a/src/python/test_perf.py b/src/python/test_perf.py
diff --git a/src/python/tests/signature_tests.py b/src/python/tests/signature_tests.py
@@ -4,58 +4,59 @@
 import pandas as pd
 from demoparser2 import DemoParser
 
+demo_path = "../parser/test_demo.dem"
 
 class SignatureTest(TestCase):
     def test_parse_header_signature(self):
-        parser = DemoParser("tests/data/test.dem")
+        parser = DemoParser(demo_path)
         header = parser.parse_header()
         self.assertIsInstance(header, dict)
         for key, value in header.items():
             self.assertIsInstance(key, str)
             self.assertIsInstance(value, str)
 
     def test_parse_convars_signature(self):
-        parser = DemoParser("tests/data/test.dem")
+        parser = DemoParser(demo_path)
         convars = parser.parse_convars()
         self.assertIsInstance(convars, dict)
         for key, value in convars.items():
             self.assertIsInstance(key, str)
             self.assertIsInstance(value, str)
 
     def test_list_game_events_signature(self):
-        parser = DemoParser("tests/data/test.dem")
+        parser = DemoParser(demo_path)
         game_events = parser.list_game_events()
         self.assertIsInstance(game_events, list)
         for event in game_events:
             self.assertIsInstance(event, str)
 
     def test_parse_grenades_signature(self):
-        parser = DemoParser("tests/data/test.dem")
+        parser = DemoParser(demo_path)
         grenades = parser.parse_grenades()
         self.assertIsInstance(grenades, pd.DataFrame)
 
     def test_parse_chat_messages_signature(self):
-        parser = DemoParser("tests/data/test.dem")
+        parser = DemoParser(demo_path)
         chat_messages = parser.parse_chat_messages()
         self.assertIsInstance(chat_messages, pd.DataFrame)
 
     def test_parse_player_info_signature(self):
-        parser = DemoParser("tests/data/test.dem")
+        parser = DemoParser(demo_path)
         player_info = parser.parse_player_info()
         self.assertIsInstance(player_info, pd.DataFrame)
 
     def test_parse_item_drops_signature(self):
-        parser = DemoParser("tests/data/test.dem")
+        parser = DemoParser(demo_path)
         item_drops = parser.parse_item_drops()
         self.assertIsInstance(item_drops, pd.DataFrame)
 
     def test_parse_skins_signature(self):
-        parser = DemoParser("tests/data/test.dem")
+        parser = DemoParser(demo_path)
         skins = parser.parse_skins()
         self.assertIsInstance(skins, pd.DataFrame)
 
     def test_parse_event_signature(self):
-        parser = DemoParser("tests/data/test.dem")
+        parser = DemoParser(demo_path)
 
         event = parser.parse_event("player_death")
         self.assertIsInstance(event, pd.DataFrame)
@@ -86,7 +87,7 @@ def test_parse_event_signature(self):
             parser.parse_event(5)
 
     def test_parse_events_signature(self):
-        parser = DemoParser("tests/data/test.dem")
+        parser = DemoParser(demo_path)
 
         events = parser.parse_events(["player_death"])
         self.assertIsInstance(events, list)
@@ -124,15 +125,15 @@ def test_parse_events_signature(self):
             parser.parse_events(5)
 
     def test_parse_voice_signature(self):
-        parser = DemoParser("tests/data/test.dem")
+        parser = DemoParser(demo_path)
         voice = parser.parse_voice()
         self.assertIsInstance(voice, dict)
         for key, value in voice.items():
             self.assertIsInstance(key, str)
             self.assertIsInstance(value, bytes)
 
     def test_parse_ticks_signature(self):
-        parser = DemoParser("tests/data/test.dem")
+        parser = DemoParser(demo_path)
 
         ticks = parser.parse_ticks(["X", "Y"])
         self.assertIsInstance(ticks, pd.DataFrame)

diff --git a/src/wasm/src/lib.rs b/src/wasm/src/lib.rs
@@ -215,13 +215,8 @@ pub fn parseTicks(
         Ok(output) => output,
         Err(e) => return Err(JsError::new(&format!("{}", e))),
     };
-    real_names.push("tick".to_owned());
-    real_names.push("steamid".to_owned());
-    real_names.push("name".to_owned());
-
     let mut prop_infos = output.prop_controller.prop_infos.clone();
     prop_infos.sort_by_key(|x| x.prop_name.clone());
-    real_names.sort();
 
     let helper = OutputSerdeHelperStruct {
         prop_infos: prop_infos,