LibWeb+LibWebView: Implement enough features for Figma to load :^) #3239
+1,038
−181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalenikaliaksandr
requested changes
Jan 14, 2025
| int height { 0 }; | ||
| }; | ||
|
|
||
| static Optional<ConvertedTexture> read_and_pixel_convert_texture_image_source(Variant<GC::Root<ImageBitmap>, GC::Root<ImageData>, GC::Root<HTMLImageElement>, GC::Root<HTMLCanvasElement>, GC::Root<HTMLVideoElement>> const& source, WebIDL::UnsignedLong format, WebIDL::UnsignedLong type, Optional<int> destination_width = OptionalNone {}, Optional<int> destination_height = OptionalNone {}) |
There was a problem hiding this comment.
can we define this function as a Gfx::Bitmap (or Gfx::ImmutableBitmap) method? it would be good to have as less code as possible inline code in generator since it's easier to read/edit with syntax highlighting.
This allows Figma WebSockets to authenticate the user.
This is the method that Figma uses to write strings into Wasm memory, using subarrays to select a particular Wasm memory address to write to.
This is required to return original references to the shaders attached to a program from getAttachedShaders. This is required for Figma (and likely all other Emscripten compiled applications that use WebGL) to get it's own generated shader IDs from the shaders returned from getAttachedShaders.
This causes it to enforce the sections "Differences Between WebGL and OpenGL ES 2.0" from the WebGL 1 specification and "Differences Between WebGL and OpenGL ES 3.0" from the WebGL 2 specification. It also disables a bunch of extensions by default, which we must now request with glRequestExtensionANGLE.
Namely: - Perform case-insensitive matching - Return the same extension objects every time - Only enable the extension if it's supported by the current context
This is done by using the combination of format and type to map to the appropriate Skia bitmap type. With this, we then read the SkImage of the TexImageSource into a new SkPixmap with the destination format information and holding an appropriately sized buffer. Once created, readPixels is called to convert and write the image into the buffer.
This is used to put together the list of supported WebGL extensions based on the available extensions, per-extension required extensions and WebGL version.
This is used on figma.com.
This is used on figma.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2025-01-13.11-25-56.mp4
Note that this crashes often, one of the most common crashes being #3051