LibURL+LibWeb: Add initial set of stubs for URLPatternInit #3224
+195
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannonbooth
force-pushed
the
urlpattern-start-upstreaming
branch
from
af4b39f to
d46a644
Compare
shannonbooth
commented
Jan 11, 2025
| // https://urlpattern.spec.whatwg.org/#dictdef-urlpatterninit | ||
| struct Init { | ||
| Optional<String> protocol; | ||
| Optional<String> username; |
There was a problem hiding this comment.
The only thing about putting it in LibURL is it will add an additional dependency on it to LibRegex, but I think that's fine
shannonbooth
force-pushed
the
urlpattern-start-upstreaming
branch
2 times, most recently
from
30e749a to
b19ead5
Compare
shannonbooth
force-pushed
the
urlpattern-start-upstreaming
branch
from
b19ead5 to
1a3c230
Compare
The URLPattern spec is intended to be implemented inside of LibURL, with LibWeb only responsible for the IDL conversion layer, in a similar manner to how URL is implemented.
shannonbooth
force-pushed
the
urlpattern-start-upstreaming
branch
from
1a3c230 to
806ee20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locally, I have ~80% of the tests passing for URLPattern spec. Some of the bugs are as a result of differences between the spec and WPT, see one reported issue on this at: whatwg/urlpattern#239, along with some bugs in my implementation that I'm working through, along with a pending bug report or two I need to make.
This begins the process of tidying up that branch from a single behemoth commit and upstreaming the changes :^)