Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for setting activity type #255

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Add support for setting activity type #255

merged 4 commits into from
Sep 19, 2024

Conversation

na-2n
Copy link
Contributor

@na-2n na-2n commented Aug 30, 2024

Fixes #251

@na-2n
Copy link
Contributor Author

na-2n commented Aug 30, 2024

went a bit out of scope of this pr and also cleaned up some duplicate code, if unwanted I'll revert it

@na-2n na-2n force-pushed the feature/activity-type branch from 8b4b063 to 3e3614c Compare August 30, 2024 19:21
@its-benjamin its-benjamin mentioned this pull request Sep 5, 2024
Closed
@na-2n
Copy link
Contributor Author

na-2n commented Sep 7, 2024

bump

Lachee
Lachee approved these changes Sep 19, 2024
View reviewed changes
Copy link
Owner

@Lachee Lachee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much better way to handle the updates.

@Lachee Lachee merged commit a523267 into Lachee:master Sep 19, 2024
1 check failed
@sll552
Copy link
Contributor

sll552 commented Oct 13, 2024

Hi,
this is a much appreciated addition, would it be possible to release a new version? thx ☺️

@JustArion JustArion mentioned this pull request Oct 15, 2024
Open
@pkg-dot-zip
Copy link

Like @sll552 I would love this to be included in a new release soon. Thank you!

@sdasda7777
Copy link

Similarly, I would also appreciate being able to use this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsTatsuya ItsTatsuya ItsTatsuya approved these changes

@Void48 Void48 Void48 approved these changes

@SapphicMoe SapphicMoe SapphicMoe approved these changes

@Lachee Lachee Lachee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding support for custom activity type
8 participants
@na-2n @sll552 @pkg-dot-zip @sdasda7777 @Lachee @SapphicMoe @Void48 @ItsTatsuya