Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add froschmc #1443

Closed
wants to merge 17 commits into from
Closed

add froschmc #1443

wants to merge 17 commits into from

Conversation

FakeBlack1
Copy link

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

Copy link
Collaborator

@DoJapHD DoJapHD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still the same changes as requested in the last PR

@FakeBlack1
Copy link
Author

hat es funktioniert?

"nice_name": "FROSCHMC",
"direct_ip": "froschmc.de",
"server_wildcards": [
"%.froschmc.de"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a real wildcard

minecraft_servers/froschmc/manifest.json Outdated Show resolved Hide resolved
],
"social": {
"web": "https://www.froschmc.de",
"web_shop": "https://froschmc.de",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not reachable

"web": "https://www.froschmc.de",
"web_shop": "https://froschmc.de",
"discord": "https://discord.gg/KKHWZpRZuM",
"teamspeak": ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

"country": "Germany",
"country_code": "DE"
},
"yt_trailer": ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

},
"chat": {
"message_formats": [
"^(|§8»\\n)(§[a-f0-9]§?l?(?<rank>\\S+))§r §8\\| §7(?<sender>[a-zA-Z0-9_]{2,16})§r §8» §7(?<message>.*)(|\\n§8»)$"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that's your regex?

@FakeBlack1 FakeBlack1 marked this pull request as draft November 10, 2024 22:37
@FakeBlack1 FakeBlack1 marked this pull request as ready for review November 11, 2024 13:47
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compress image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compress image

@FakeBlack1 FakeBlack1 closed this Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants