Drg tools/modules cleanup #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Note: TODOs should be resolved before merging!
There are a few lines where I added
TODO: VERIFYand a note. In these places, I added my best guess at a fix, but I want to confirm that my change is in line with the intended usage of the relevant code.See:
final_convolution.__init__Kernel_linear.__init__If these changes look acceptable, let me know and I'll remove the TODOs/NOTEs and update my PR. Otherwise, please let me know the expected implementation here and I can update the code accordingly. Thanks!