Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

U/troxel/diffsky #81

Merged
merged 22 commits into from
Nov 29, 2023
Merged

U/troxel/diffsky #81

merged 22 commits into from
Nov 29, 2023

Conversation

JoanneBogart
Copy link
Collaborator

@JoanneBogart JoanneBogart commented Nov 28, 2023 •
edited
Loading

  1. Create catalogs, including SEDs (in hdf5 files, separate from the usual parquet files), from diffsky input
  2. Optionally include Roman fluxes in flux files and generate them on the fly for SNANA objects, just as is done for LSST fluxes
  3. Improve knots representation

matroxel and others added 22 commits November 21, 2023 15:03
@matroxel
Added diffsky object types
567cd33
@matroxel
Added diffsky compatitbility and functionality to calculate roman gal…
10487dd 
…axy fluxes
@matroxel
Added functionality to calculate roman fluxes
e15cf82
@matroxel
Fixed bug with inhereting random seed for knot positions. Added non-p…
7813241 
…oint-like knot sizes, and distribution based on disk profile.
@matroxel
New diffsky object class
0dc04b5
@matroxel
Added functionality to calculate roman fluxes
db907cb
@matroxel
Added diffsky functionality
7e4484b
@matroxel
Added diffsky functionality. Added roman flux functionality.
16313f4
@matroxel
Updated schema to allow for diffsky objects and roman fluxes
4169661
@matroxel
Added diffsky sed class.
da65785
@matroxel
Updated null test for n_knots to be compatible with non-zero knot size.
d123304
@matroxel
Added class to generate diffsky SEDs and write to hdf5 files.
57ac013
@matroxel
Fix for bug in knot implementation for galaxy obj type. Adds knot com…
a817e70 
…ponent back to obj_dict.
@JoanneBogart
Fix comment text; other cosmetic changes
75b5be7
@JoanneBogart
Factor out common flux correction code for LSST, Roman
fb48391
@JoanneBogart
factor out repeated code in parquet_schema_utils.py; other cosmetic c…
b6232d9 
…hanges
@JoanneBogart
Change classnames diffSkySedFactory, diffSkySedGenerator to DiffskySe…
ec0d34f 
…d...; other cosmetic changes for flake8
@JoanneBogart
slightly increment version
bfe72b4
@JoanneBogart
attempt to fix broken ci by following imSim model
7a23c86
@JoanneBogart
attempt #2 to fix broken ci
b404d97
@JoanneBogart
attempt #3 to fix broken ci
dafef5c
@JoanneBogart
1. For cat. creation include option for Roman fluxes 2. Use standard …
79ea203 
…GCRCatalogs 3. Add SSP file needed for diffsky SED calculations to data directory
@JoanneBogart JoanneBogart self-assigned this Nov 29, 2023
matroxel
matroxel approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@matroxel matroxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some minor changes to smooth over rough edges and some testing to make sure nothing got broken, this looks ok. More updates coming soon in another PR or two.

@JoanneBogart JoanneBogart merged commit 8318bbf into main Nov 29, 2023
1 check passed
@JoanneBogart JoanneBogart deleted the u/troxel/diffsky branch November 29, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matroxel matroxel matroxel approved these changes

Assignees

@JoanneBogart JoanneBogart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoanneBogart @matroxel