adding knot size following disk profile #79
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update adds non-zero sizes to the knot component of the profile, fixed to 250pc. Also changes distribution of knot locations to follow the disk profile, rather than a gaussian. A comparison of the impact of the changes follows.
Top: Version in main; Bottom: pull request update
Left: bulge component included; Right: Bulge component turned off.
(note, random seed not fixed between panels in test, so knot locations change)