-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add random forest classifier for tomographer #1
Conversation
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
Unit tests pass on local machine but not on GitHub. Waiting for new release of rail to include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I requested some minor changes to the class names for consistency and made the suggestion to isolate the color-making function in this module to make it easy to swap out when we unify all the calculations of colors that appear in so many of the algos modules.
name = 'randomForestClassifier' | ||
config_options = CatClassifier.config_options.copy() | ||
config_options.update( | ||
id_name=Param(str, "", msg="Column name for the object ID in the input data, if empty the row index is used as the ID."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing needs to be changed here, but I just want to note re: LSSTDESC/rail_base#39 that this will be the first instance of IDs in the RAIL-iverse so should be considered in decision-making about how to consistently reference these throughout src/rail
code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! This can be merged as soon as the tests are passing.
Change Description
Solution Description
Moved random forest classifier for the tomographer class from rail_base to rail_sklearn due to its dependence on sklearn.
Code Quality
Project-Specific Pull Request Checklists
Bug Fix Checklist
New Feature Checklist
Documentation Change Checklist
Build/CI Change Checklist
Other Change Checklist