Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependencies on .columns file #53 #54

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Conversation

sschmidt23
Copy link
Collaborator

Quick PR to remove the dependence on the legacy .columns file to read in the filters that DESC_BPZ and the original BPZ code use. Replace with a list of the filters that needs to be in the same order and the bands and err_bands.

I'll separately create an issue in the rail repo and update the demo notebook there to mention the new filter_list and its usage.

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d3306df) to head (f497d1c).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          242       242           
=========================================
  Hits           242       242           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@eacharles eacharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sam.

@sschmidt23 sschmidt23 merged commit deefe81 into main Sep 20, 2024
7 checks passed
@sschmidt23 sschmidt23 deleted the issue/53/nocolumns branch September 20, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants