add check of f0 sum, norm if >1 #45 #46
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem & Solution Description (including issue #)
Addresses the problem in issue #45 where the fractions f0 can sum to more than 1, which will force the last type to go negative at the m0 value and nearby values. I added an if statement and division to set to 1.0 if >1, which fixes the issue in tests that I ran. I'm not adding a unit test because the nelder-mead minimizer is fickle and it's sometimes hard to trigger, plus I have tested it in notebooks and it works as expected.
Code Quality
#pragma: no cover
; in the case of a bugfix, a new test that breaks as a result of the bug has been added