Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

45 parallelize point est hist and naive stack #64

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

joselotl
Copy link
Contributor

Problem & Solution Description (including issue #)

This PR parallelizes naive stack. It modifies some of the logic from input_iterator and adds functions to data.py in order to be able to use the iterator to qp ensambles.

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

@joselotl joselotl linked an issue Oct 27, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (da3a845) 97.13% compared to head (0f62392) 96.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   97.13%   96.95%   -0.18%     
==========================================
  Files          32       32              
  Lines        1675     1709      +34     
==========================================
+ Hits         1627     1657      +30     
- Misses         48       52       +4     
Files Coverage Δ
src/rail/core/stage.py 99.14% <100.00%> (+0.03%) ⬆️
src/rail/core/data.py 99.23% <88.88%> (-0.37%) ⬇️
src/rail/estimation/algos/naive_stack.py 94.73% <90.62%> (-5.27%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eacharles eacharles force-pushed the 45-parallelize-point_est_hist-and-naive_stack branch from b3575a3 to 0f62392 Compare October 30, 2023 21:16
@eacharles eacharles self-requested a review October 30, 2023 21:26
Copy link
Collaborator

@eacharles eacharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We need to figure out how to test his under MPI with the new pyproject.toml / github actions, but that is a different question

@eacharles eacharles merged commit 4e93655 into main Oct 30, 2023
4 of 6 checks passed
@eacharles eacharles deleted the 45-parallelize-point_est_hist-and-naive_stack branch April 3, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parallelize point_est_hist and naive_stack
2 participants