Implement placeholders for dummy estimators/summarizers #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 96.71% 97.12% +0.41%
==========================================
Files 32 32
Lines 1642 1671 +29
==========================================
+ Hits 1588 1623 +35
+ Misses 54 48 -6
☔ View full report in Codecov by Sentry. |
drewoldag
commented
Oct 5, 2023
| config_options = RailStage.config_options.copy() | ||
| config_options.update(hdf5_groupname=str, save_train=True) |
There was a problem hiding this comment.
This line doesn't seem to be required - all the subsequent logic is configured to check first for the presence of hdf5_groupname and save_train prior to working with either of those.
drewoldag
changed the title
…ified base classes: `informer.py` and `summarizer.py`.
eacharles
force-pushed
the
issue/1/placeholder-informers
branch
from
0c1f22a
to
1bc1c14
Compare
eacharles
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing placeholders for the following dummy estimators/summarizers: