Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add COSMOS SEDs as additional template set #166 #167

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

sschmidt23
Copy link
Collaborator

Adds the COSMOS 30-band SEDs to the examples_data so users can easily run with a slightly expanded template set that is likely to perform better than the "default" CWWSB template set. I also included a prior file that uses the same HDFN parameters as the original BPZ prior, but with the appropriate numbers of SEDs per broad type for this set of 31 SEDs.

To go with this, I'll put in another PR to the rail repo to update the BPZ demo notebook so that it also runs this SED set and compares to the CWWSB set.

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

@sschmidt23 sschmidt23 linked an issue Oct 1, 2024 that may be closed by this pull request
3 tasks
Copy link
Contributor

@hangqianjun hangqianjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sschmidt23 sschmidt23 merged commit a6d1d4a into main Oct 2, 2024
5 checks passed
@sschmidt23 sschmidt23 deleted the issue/166/cosmosseds branch October 2, 2024 20:42
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.35%. Comparing base (30a570f) to head (7e02a63).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files          45       45           
  Lines        2497     2497           
=======================================
  Hits         2456     2456           
  Misses         41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add COSMOS SEDs to SED folder for alternate to CWWSB set
2 participants