Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy pupil coords #477

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Copy pupil coords #477

merged 2 commits into from
Jun 7, 2024

Conversation

jmeyers314
Copy link
Member

Addresses #475 .

@jmeyers314 jmeyers314 requested a review from rmjarvis June 7, 2024 20:29
rmjarvis
rmjarvis approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@rmjarvis rmjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

FWIW, I usually use a.copy() as a more concise equivalent to np.array(a, copy=True). But what you have is fine if you prefer the longer version.

@jmeyers314 jmeyers314 merged commit c85d643 into main Jun 7, 2024
3 checks passed
@jmeyers314 jmeyers314 deleted the copy_pupil_coords branch June 7, 2024 21:28
@jmeyers314 jmeyers314 mentioned this pull request Jun 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmjarvis rmjarvis rmjarvis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmeyers314 @rmjarvis