Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make config template input-type independent. #393

Merged
merged 24 commits into from
Aug 5, 2023
Merged

Make config template input-type independent. #393

merged 24 commits into from
Aug 5, 2023

Commits on Jul 31, 2023

  1. Try using nested templates.

    @cwwalter
    cwwalter committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    9b96db3 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. This doesn't actually work yet. 

    Need to wait for GalSim v2.5.
    @cwwalter
    cwwalter committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    999444c View commit details
    Browse the repository at this point in the history

  2. Remove blank line.

    @cwwalter
    cwwalter committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    d7138d6 View commit details
    Browse the repository at this point in the history

  3. Rename to be instcat specific

    @cwwalter
    cwwalter committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    e3cc28e View commit details
    Browse the repository at this point in the history

  4. Remove items specific to intCats

    @cwwalter
    cwwalter committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    a1db8b6 View commit details
    Browse the repository at this point in the history

  5. Make template config files. 

    These are templates that the user can copy and add to for
each instance type.

With GalSim 2.5 these will become templates.
    @cwwalter
    cwwalter committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    bc200af View commit details
    Browse the repository at this point in the history

  6. Galaxy type piece somehow missed by git..

    @cwwalter
    cwwalter committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    2260384 View commit details
    Browse the repository at this point in the history

  7. Add examples using templates. 

    Including adding a new skycatalog template.
    @cwwalter
    cwwalter committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    e905051 View commit details
    Browse the repository at this point in the history

  8. Make the CI use examples.

    @cwwalter
    cwwalter committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    59976f2 View commit details
    Browse the repository at this point in the history

  9. Remove early text about DC2/previous imSim. 

    Make clear what the file is for.
    @cwwalter
    cwwalter committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    7b960e3 View commit details
    Browse the repository at this point in the history

  10. Remove white space

    @cwwalter
    cwwalter committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    6d8bbf0 View commit details
    Browse the repository at this point in the history

  11. Copied before modifying a line.

    @cwwalter
    cwwalter committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    5033754 View commit details
    Browse the repository at this point in the history

  12. YAML keys are fiddly 

    Can't redefine if not used before.  But, careful not to wipe
out whole section.
    @cwwalter
    cwwalter committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    624efda View commit details
    Browse the repository at this point in the history

  13. Can't modify unset YAML items.

    @cwwalter
    cwwalter committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    1884db0 View commit details
    Browse the repository at this point in the history

  14. Extend readme file explanation.

    @cwwalter
    cwwalter committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    c318902 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Change to use specific templates. 

    Until GalSim supports nested templates, manually copy the information
into the config files. Also, rename files and register them with the
template system.
    @cwwalter
    cwwalter committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    930c95f View commit details
    Browse the repository at this point in the history

  2. File name fix.

    @cwwalter
    cwwalter committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    91e08b1 View commit details
    Browse the repository at this point in the history

  3. Manually insert YAML elements. 

    It seems appending YAML elements in . notation doesn't work.
So, for now, manually insert the elements in the yaml sections.

This is dangerous! Hopefully this will be replaced by a nested template
soon.  We have to be careful to not let config files get out of sync.
Now nothing should be using the core imsim-config.yaml file.

Also, update two tests to use the instcat config file.
    @cwwalter
    cwwalter committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    bd31fd4 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Update usage docs to use new template.

    @cwwalter
    cwwalter committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    26b072f View commit details
    Browse the repository at this point in the history

  2. Edit internal comments in instcat template.

    @cwwalter
    cwwalter committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    f8ab7cc View commit details
    Browse the repository at this point in the history

  3. Edit comments in skycat template.

    @cwwalter
    cwwalter committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    ef2cd6b View commit details
    Browse the repository at this point in the history

  4. Edit example file comments

    @cwwalter
    cwwalter committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    9c25890 View commit details
    Browse the repository at this point in the history

  5. Move flat-*.yaml files to examples directory. 

    Also update CI.
    @cwwalter
    cwwalter committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    272869d View commit details
    Browse the repository at this point in the history

  6. Update README file.

    @cwwalter
    cwwalter committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    32ca018 View commit details
    Browse the repository at this point in the history