Allow for Signal.signal choices to be configured #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a DB_MAILER_SIGNAL_CHOICES setting. It also changes signal values from expecting to be a name for a member in the module `django.db.models.signals` and now expects a full path to a signal. This allows user to specify other signals that they may choose to define. The migrations will rename all records in the database that uses the previous naming convention.
|
It looks like travis passed 11 out of 12 of the tests. Failed on the python3.5 with DJANGO=1.9.12 build when trying to pip install requests. |
|
Hello @kaleb! What problems do this PR resolves? Why do you need it? |
|
I have some custom signals that I would like to use.
…On Wed, Sep 5, 2018, 3:44 AM Vadim Laletin ***@***.***> wrote:
Hello @kaleb <https://github.com/kaleb>! What problems do this PR
resolves? Why do you need it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#102 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAekZJwp0h3U0msTs4NZXgry8skGIIkqks5uX4DTgaJpZM4RhWvr>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a DB_MAILER_SIGNAL_CHOICES setting. It also changes signal
values from expecting to be a name for a member in the module
django.db.models.signalsand now expects a full path to a signal.This allows user to specify other signals that they may choose to
define. The migrations will rename all records in the database that
uses the previous naming convention.
Before to submit your pull-request: