Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Oscar code to version 1.0 #6128

Merged
merged 1 commit into from
Aug 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lmfdb/elliptic_curves/code.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ curve:
sage: E = EllipticCurve({ainvs})
pari: E = ellinit({ainvs})
magma: E := EllipticCurve({ainvs});
oscar: E = EllipticCurve({ainvs})
oscar: E = elliptic_curve({ainvs})

simple_curve:
sage: E.short_weierstrass_model()
Expand Down
2 changes: 1 addition & 1 deletion lmfdb/number_fields/code.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ field:
sage: x = polygen(QQ); K.<a> = NumberField(%s)
pari: K = bnfinit(%s, 1)
magma: R<x> := PolynomialRing(Rationals()); K<a> := NumberField(%s);
oscar: Qx, x = PolynomialRing(QQ); K, a = NumberField(%s)
oscar: Qx, x = polynomial_ring(QQ); K, a = number_field(%s)

poly:
sage: K.defining_polynomial()
Expand Down
4 changes: 2 additions & 2 deletions lmfdb/number_fields/number_field.py
Original file line number Diff line number Diff line change
Expand Up @@ -776,15 +776,15 @@ def interesting():
'gp' : '',
'magma' : 'R<x> := PolynomialRing(Rationals());',
'mathematica' : '',
'oscar' : 'Rx, x = PolynomialRing(QQ)',
'oscar' : 'Rx, x = polynomial_ring(QQ)',
'sage' : 'x = polygen(QQ)',
}

download_makedata = {
'gp' : '', # don't try to make fields in gp, even with nfinit it may take a very long time
'magma' : 'function make_data() return [NumberField(r[2]) : r in data]; end function;',
'mathematica' : '',
'oscar' : 'function make_data() return [NumberField(r[2]) for r in data] end',
'oscar' : 'function make_data() return [number_field(r[2]) for r in data] end',
'sage' : 'def make_data(): return [NumberField(r[1],"a") for r in data]',
}
download_makedata_comment = {
Expand Down
Loading