Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php_8_4 #72

Merged
merged 11 commits into from
Nov 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ jobs:
build:
strategy:
matrix:
php_version: ['8.1', '8.2', '8.3']
php_version: ['8.1', '8.2', '8.3', '8.4']
deps: ['--prefer-lowest', '--prefer-dist']
include:
- code-coverage: 'yes'
php_version: '8.2'
php_version: '8.3'
deps: ''

runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
}
},
"require": {
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0 || ~8.4.0",
"laminas/laminas-eventmanager": "^2.6.4 || ^3.2.1",
"laminas/laminas-http": "^2.10",
"laminas/laminas-mvc": "^2.7.15 || ^3.1.1",
Expand Down
93 changes: 47 additions & 46 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/Service/CorsService.php
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public function createPreflightCorsResponse(HttpRequest $request): HttpResponse
*
* @return HttpResponse
*/
public function createPreflightCorsResponseWithRouteOptions(HttpRequest $request, RouteMatch $routeMatch = null): HttpResponse
public function createPreflightCorsResponseWithRouteOptions(HttpRequest $request, RouteMatch|null $routeMatch = null): HttpResponse
{
$options = $this->options;
if ($routeMatch instanceof RouteMatch) {
Expand All @@ -149,7 +149,7 @@ public function createPreflightCorsResponseWithRouteOptions(HttpRequest $request
* @return HttpResponse
* @throws DisallowedOriginException If the origin is not allowed
*/
public function populateCorsResponse(HttpRequest $request, HttpResponse $response, RouteMatch $routeMatch = null): HttpResponse
public function populateCorsResponse(HttpRequest $request, HttpResponse $response, RouteMatch|null $routeMatch = null): HttpResponse
{
if ($routeMatch instanceof RouteMatch) {
$this->options->setFromArray($routeMatch->getParam(CorsOptions::ROUTE_PARAM) ?: []);
Expand Down
2 changes: 1 addition & 1 deletion tests/Util/ServiceManagerFactory.php
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public static function getApplicationConfig(): array
* @throws ContainerExceptionInterface
* @throws NotFoundExceptionInterface
*/
public static function getServiceManager(array $config = null): ServiceManager
public static function getServiceManager(array|null $config = null): ServiceManager
{
$config = $config ?: static::getApplicationConfig();
$serviceManager = new ServiceManager();
Expand Down