Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: incorrect callsite stack traceback during .so file handling #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sb17v
Copy link

@sb17v sb17v commented Feb 2, 2024

Read the offset from /proc/<pid #>/maps and add it to PC to handle callsite stack traceback correctly for .so files

Co-authored-by: Artem Polyakov <[email protected]>
Signed-off-by: Subhadeep Bhattacharya <[email protected]>
@artpol84
Copy link
Contributor

artpol84 commented Feb 2, 2024

@cchambreau we were trying to profile some MPI application and noticed that the call stack is broken.
IMO it’s one of the greatest features in mpiP so we thought it should be fixed

@artpol84
Copy link
Contributor

artpol84 commented Feb 2, 2024

@sb17v patch looks clean, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants