-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor fix and a unit test for NNLSSolver #271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamer2368
force-pushed
the
par-nnls
branch
from
February 15, 2024 04:57
b1bb2b3
to
929a422
Compare
dreamer2368
force-pushed
the
par-nnls
branch
from
February 15, 2024 04:59
929a422
to
458baee
Compare
dreamer2368
requested review from
ckendrick,
dylan-copeland,
chldkdtn and
siuwuncheung
February 15, 2024 05:00
dreamer2368
changed the title
a unit test for NNLSSolver::solve_parallel_with_scalapack.
minor fix and a unit test for NNLSSolver
Feb 28, 2024
dylan-copeland
approved these changes
Mar 5, 2024
ckendrick
reviewed
Mar 5, 2024
ckendrick
approved these changes
Mar 5, 2024
andersonw1
pushed a commit
that referenced
this pull request
Apr 2, 2024
* a unit test for NNLSSolver::solve_parallel_with_scalapack. * minor update in parameters. * L2 norm criterion and minor fix. * stylization * reflecting the comments. * carom verify termination * stylization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor fix/update for NNLSSolver
n_dist_loc_max
fixIn
NNLSSolver::solve_parallel_with_scalapack
,n_dist_loc_max
is now determined fromn_tot
, notm
(as it is supposed to).n_dist_loc_max
only determines the memory size of the working array, not impacting the NNLS solution. Before this fix, the following working array variables were allocated with unnecessarily large sizes:hard-coded limit for number of processors
Per issue #269 , the number of processors that can be used for NNLSSolver is limited to
15
. This limit is removed and tested through the unit test below.termination criterion for NNLSSolver
Previously, NNLS iteration is terminated when$L_{\infty}$ -norm (the maximum value) of the residual vector is below the threshold. Now NNLSSolver has an option to terminate when $L_2$ -norm of the residual vector is below a corresponding threshold. This is set at initialization with the input argument
NNLS_termination criterion
.unit test for NNLSSolver
A unit test for
NNLSSolver::solve_parallel_with_scalapack
is added.This checks the solution approximates the system with desired tolerance, both in serial and parallel.
On LC quartz, the scaling test result is: (for
300x1000
)Another test with a larger system (
500x15000
):This timing includes the entire setup for matrix-vector system aside from
solve_parallel_with_scalapack
.