-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor examples #253
Refactor examples #253
Conversation
@jtlau I'm using the general |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
combine_samples
looks good to me. Thanks for updating it!
This PR needs one more reviewer, @ckendrick @dylan-copeland @dreamer2368 , anyone volunteer? |
This is a WIP, not RFR. |
Oh, I thought this was RFR. @siuwuncheung Can you confirm? |
At this point, I put this PR as RFR. Besides
A good point suggested by @dylan-copeland is that, we make deep copies of the matrices in these routines. When they are moved to the library, we'd probably want to find a way to avoid the entire matrix deep copy. However, it is non-trivial since matrices are row-based and we need columns. |
* Add example results * Count DMD prediction timer only at final time * Move final summary for basis generator into library * Stylize * Add finalSummary to combine_samples * Enable capabilities in combine_samples.cpp * Astyle * Remove spaces * Run astyle * Change to 1-base * Change comments * Change to energy fraction threshold * Pass the string by reference * Astyle * Modify brief * Run astyle
BasisGeneratorFinalSummary
in two MFEM PROM examples is replaced byfinalSummary
inBasisGenerator
class. (BasisGeneratorFinalSummary
in Laghos can be replaced as well.)BasisGenerator
class,loadSampleRange
routine is added to enable the capability of using selected range of snapshot indices fromcol_min
tocol_max
inclusive. TheloadSample
routine is now based onloadSampleRange
using all indices.