De advection greedy #250
Merged
De advection greedy #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptranq
requested review from
dylan-copeland,
dreamer2368,
chldkdtn,
andersonw1 and
siuwuncheung
delting empty lines and commented sections. Did not yet change example output to a different folder.
ckendrick
requested changes
Jan 2, 2024
subfolder. Individual subfolders can be used to store output, or to load input. Additionally, I have addressed minor comments in PR#250.
since these needed to be the same for successful execution.
ckendrick
reviewed
Jan 16, 2024
ckendrick
requested changes
Jan 16, 2024
ckendrick
approved these changes
Jan 17, 2024
dylan-copeland
approved these changes
Jan 20, 2024
andersonw1
pushed a commit
that referenced
this pull request
Apr 2, 2024
* Added optimal control for dg_advection. * Added de_dg_advection_greedy to CMakeLists.txt, so the new example will compile. * Improved the introductory comments, included example run commands and output * Applied sylize script to code. * Turned back on DMD visualization. * Ran styleize script. * Addressed most comments from Dylan. Minor code style changes, delting empty lines and commented sections. Did not yet change example output to a different folder. * Modified example de_dg_advection_greedy to place output files in a subfolder. Individual subfolders can be used to store output, or to load input. Additionally, I have addressed minor comments in PR#250. * Modified the input and output directories, to be only a single io_dir since these needed to be the same for successful execution. * Created iodir if it does not already exist. Added timers per CKendrick's suggestion * Changed the method of subfolder creation. * Addressed minor comments and updated copyright year.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds de_dg_advection_greedy example.