Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the compiler a variant #552

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Making the compiler a variant #552

merged 2 commits into from
Jan 21, 2025

Conversation

pearce8
Copy link
Collaborator

@pearce8 pearce8 commented Jan 20, 2025

Description

On command line, optionally specify "compiler=...." in "system init" to change the compiler.

Dependencies: None.

Fixes issue(s): n/a

Type of Change

  • { } Adding a system, benchmark, or experiment
  • {X} Modifying an existing system, benchmark, or experiment
  • { } Documentation update
  • { } Build/CI update
  • { } Benchpark core functionality

Checklist:

If adding/modifying a system:

  • { } Create a new directory for the system and a new system.py file
  • { } Add a new dry run unit test in .github/workflows
  • { } System appears in System Specifications table in docs catalogue section

If adding/modifying a benchpark:

  • { } Add a new application.py and (maybe) package.py under a new directory
    for this benchmark
  • { } Configure an experiment
  • { } Benchmark appears in Benchmarks and Experiments table in docs catalogue
    section

If adding/modifying a experiment:

  • { } Extend experiment.py under existing directory for specific benchmark
  • { } Define a single node and multi-node experiments

If adding/modifying core functionality:

  • { } Update docs
  • { } Update .github/workflows and .gitlab/ci unit tests (if needed)

On command line, optionally specify "compiler=...." in "system init" to change the compiler.
@pearce8 pearce8 requested a review from SBA0486 January 21, 2025 00:42
@pearce8 pearce8 self-assigned this Jan 21, 2025
Copy link
Collaborator

@SBA0486 SBA0486 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The string {self.spec.variants["compiler"][0]} is not interpreted and leads to the following error:
Error: Error parsing yaml in "/saxpy-openmp/Fugaku-ffa9e24/workspace/configs/software.yaml", line 4, column 17: expected ',' or '}', but got '['

@pearce8
Copy link
Collaborator Author

pearce8 commented Jan 21, 2025

@SBA0486 I added quotes, please try again.

@pearce8 pearce8 merged commit 40685e0 into develop Jan 21, 2025
8 checks passed
@pearce8 pearce8 deleted the pearce8-patch-fujitsu branch January 21, 2025 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants