Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds file and line number info to debug statements #233

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rountree
Copy link
Collaborator

@rountree rountree commented May 7, 2024

Description

e.g.,

(debug) benchpark::72 Hello, world!

Dependencies: FIXME:Add a list of any dependencies.

Fixes #232

Type of Change

  • { } Adding a system, benchmark, or experiment
  • { } Modifying an existing system, benchmark, or experiment
  • { } Documentation update
  • { } Build/CI update
  • { } Benchpark core functionality

Checklist:

If adding/modifying a system:

  • { } Create a new directory for the system and a new system.py file
  • { } Add a new dry run unit test in .github/workflows
  • { } System appears in System Specifications table in docs catalogue section

If adding/modifying a benchpark:

  • { } Add a new application.py and (maybe) package.py under a new directory
    for this benchmark
  • { } Configure an experiment
  • { } Benchmark appears in Benchmarks and Experiments table in docs catalogue
    section

If adding/modifying a experiment:

  • { } Extend experiment.py under existing directory for specific benchmark
  • { } Define a single node and multi-node experiments

If adding/modifying core functionality:

  • { } Update docs
  • { } Update .github/workflows and .gitlab/ci unit tests (if needed)

@pearce8 pearce8 requested a review from scheibelp May 7, 2024 19:05
e.g.,

(debug) benchpark::72 Hello, world!
@pearce8 pearce8 marked this pull request as draft December 9, 2024 19:52
@pearce8
Copy link
Collaborator

pearce8 commented Dec 9, 2024

Marking this one draft since it is so far out of date. @scheibelp please cherry-pick these commits onto new develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add file and line number information to debug_print
3 participants