-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuzzyhashing #152
Fuzzyhashing #152
Conversation
Awesome! I'm out this upcoming week on vacation with limited internet access, so I might not be able to fully review the changes until March 11. Initial thoughts are that overall it looks good, the main things are:
|
for more information, see https://pre-commit.ci
The requested changes have been made. Also I made SSDEEP its own dependency group, and check whether we can import it. If we can't we just run with TLSH, hopefully that should simplify things. |
@nightlark Would you be able to review the most recent changes? |
The check for SSDEEP as an optional dependency looks like a good option -- I opened an issue on the python-ssdeep repository about pre-compiled binary wheels for common platforms, and checking on the maintenance status. It seems like the python-ssdeep package likely doesn't have an active maintainer at the moment. |
Co-authored-by: Ryan Mast <[email protected]>
Co-authored-by: Ryan Mast <[email protected]>
Co-authored-by: Ryan Mast <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some issues with ssdeep, which I think are related to the ssdeep python package itself (build errors, returned string from ssdeep.hash a string in the form b'<hash>'
which looks like it is returning bytes turned into a str instead of just a str).
Summary
If merged this pull request will address #149
Proposed changes
This request adds a fuzzy hash plugin using SSDEEP and TLSH. It places output in the metadata field of the main output BOM.