Rough implementation of scan algorithm. #1776
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrBurmark
reviewed
Dec 4, 2024
long58
commented
Dec 4, 2024
…into feature/long58/sycl_scan_sort
…into feature/long58/sycl_scan_sort
rhornung67
reviewed
Dec 19, 2024
rhornung67
reviewed
Dec 19, 2024
rhornung67
reviewed
Dec 19, 2024
MrBurmark
reviewed
Dec 20, 2024
| { | ||
| // ::sycl::joint_inclusive_scan() | ||
| using std::distance; | ||
| std::copy(begin, end, out); |
MrBurmark
reviewed
Dec 20, 2024
Comment on lines
+76
to
+77
| auto buffAccessor = buffPtr->get_access(cgh); | ||
| auto tempAccessor = tempPtr->get_access(cgh); |
There was a problem hiding this comment.
I'm not familiar with how sycl::buffer objects work, do they make a copy of the data?
MrBurmark
reviewed
Dec 20, 2024
| { | ||
| ::sycl::queue* sycl_queue = sycl_res.get_queue(); | ||
|
|
||
| using valueT = typename std::remove_reference<decltype(*begin)>::type; |
There was a problem hiding this comment.
Probably best to use iterator_traits https://en.cppreference.com/w/cpp/iterator/iterator_traits
MrBurmark
reviewed
Dec 20, 2024
| ii++; | ||
| } while ( ii <= iterations); | ||
|
|
||
| sycl_res.wait(); |
There was a problem hiding this comment.
Should this wait be conditional on Async from the policy?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds sycl scan algorithm