Add resource argument to PluginStrategy methods #1775
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrBurmark
reviewed
Nov 26, 2024
Comment on lines
+271
to
+272
| // todo(bowen) do we want default resource here? | ||
| util::callPreCapturePlugins(context, resource_type::get_default()); |
MrBurmark
reviewed
Nov 26, 2024
| @@ -229,24 +229,24 @@ void launch(LaunchParams const &launch_params, const char *kernel_name, ReducePa | |||
| auto&& launch_body = expt::get_lambda(std::forward<ReduceParams>(rest_of_launch_args)...); | |||
|
|
|||
| //Take the first policy as we assume the second policy is not user defined. | |||
| //We rely on the user to pair launch and loop policies correctly. | |||
| //We rely on the user to pair launch and loop policies core_protly. | |||
MrBurmark
reviewed
Nov 26, 2024
| @@ -14,8 +14,8 @@ class CounterPlugin : | |||
| public RAJA::util::PluginStrategy | |||
| { | |||
| public: | |||
| void preCapture(const RAJA::util::PluginContext& p) override { | |||
| if (p.platform == RAJA::Platform::host) | |||
| void preCapture(const RAJA::util::PluginContext& p, const RAJA::resources::Resource&) override { | |||
There was a problem hiding this comment.
Let's double check that we don't need a non-const resource reference.
|
Thanks for working on this, on my side I need a small modification on the PluginContext as its where I am storing the kernel name for the caliper integration. See here: #1773. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Design review (for API changes or additions---delete if unneeded)
On (date), we reviewed this PR. We discussed the design ideas:
This PR implements 1. and 3. It leaves out 2. for the following reasons