OpenMP Target Testing #1762
Merged
OpenMP Target Testing #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrBurmark
reviewed
Nov 8, 2024
|
|
||
| endif() | ||
| endif() | ||
| ##if(RAJA_ENABLE_TARGET_OPENMP) |
There was a problem hiding this comment.
This one's commented out but many others are removed?
There was a problem hiding this comment.
Thanks. I missed that during my cleanup pass.
MrBurmark
approved these changes
Nov 8, 2024
|
Note that 'test-resource-MultiStream-OpenMPTarget.exe' fails occasionally, more so in GitLab CI than when running tests manually. We'll have to keep an eye on it -- possibly disable if it becomes a problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleans up OpenMP Target testing by doing the following:
Enabling all OpenMP Target tests that build and run correctly
Disabling tests that have compilation or run issues (e.g., OpenMP Target tests that use the "traditional" RAJA reduction interface, back-end support is missing, cause LLVM front-end crashes, etc.)
Making CMakeLists.txt files in test directories more consistent w.r.t. how tests are enabled or disabled
It also adds a working GItLab CI test jobs for lassen.
Several RAJA issues have been added to capture tasks for future work.