Fix OpenMP Launch Mem Leak and Add Clang Sanitizer Build #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchen20
requested review from
rhornung67,
artv3,
MrBurmark,
adayton1,
johnbowen42 and
long58
MrBurmark
reviewed
Sep 4, 2024
MrBurmark
approved these changes
Sep 4, 2024
rhornung67
approved these changes
Sep 4, 2024
artv3
reviewed
Sep 4, 2024
| @@ -77,6 +77,9 @@ struct LaunchExecute<RAJA::omp_launch_t> { | |||
| ctx.shared_mem_ptr = (char*) malloc(launch_params.shared_mem_size); | |||
|
|
|||
| expt::invoke_body(f_params, loop_body.get_priv(), ctx); | |||
|
|
|||
| free(ctx.shared_mem_ptr); | |||
| ctx.shared_mem_ptr = nullptr; | |||
artv3
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a bugfix
It does the following:
Note: Does not fix the OpenMP Launch reduction tests. Will iterate with LC on those.