Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿฉน Fix: ๋ถ€์Šค ๋ฆฌ์ŠคํŠธ & ๋””ํ…Œ์ผ - ๋Œ€๊ธฐ ํŒ€ ์ˆ˜, ๋‚ด ์•ž์— ๋Œ€๊ธฐ ํŒ€ ์ˆ˜, ๋‚ด waiting_id ์ˆ˜์ • ๋ฐ ์ถ”๊ฐ€ #104

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

dudtlstm
Copy link
Contributor

@dudtlstm dudtlstm commented Oct 7, 2024

๐Ÿ”ฅ Pull requests

๐Ÿ‘ท ์ž‘์—…ํ•œ ๋‚ด์šฉ

  1. ๋ถ€์Šค ๋ฆฌ์ŠคํŠธ
  • ์ „์ฒด ๋Œ€๊ธฐ ํŒ€ ์ˆ˜๊ฐ€ ['waiting','ready_to_confirm','confirmed'] ์ด๊ฑฐ ์„ธ ๊ฐœ ์ƒํƒœ์ผ ๋•Œ๋งŒ ํฌํ•จ๋˜๊ฒŒ
  1. ๋ถ€์Šค ๋””ํ…Œ์ผ
  • ์ „์ฒด ๋Œ€๊ธฐ ํŒ€ ์ˆ˜๊ฐ€ ['waiting','ready_to_confirm','confirmed'] ์ด๊ฑฐ ์„ธ ๊ฐœ ์ƒํƒœ์ผ ๋•Œ๋งŒ ํฌํ•จ๋˜๊ฒŒ
  • ๋‚ด ์•ž ๋Œ€๊ธฐ ํŒ€ ์ˆ˜ ['waiting','ready_to_confirm','confirmed'] ์ด๊ฑฐ ์„ธ ๊ฐœ ์ƒํƒœ์ผ ๋•Œ๋งŒ ํฌํ•จ๋˜๊ฒŒ , ๋‚˜๋ณด๋‹ค ๋“ฑ๋ก ์‹œ์  ์•ž์ธ ํŒ€๋งŒ
  • ๋‚ด๊ฐ€ ๋Œ€๊ธฐ ์ค‘์ด๋ฉด(is_waiting=true) waiting_id ๋ฐ˜ํ™˜

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

๋ถ€์Šค ๋””ํ…Œ์ผ

  • ๋Œ€๊ธฐ ์ค‘ ์•„๋‹ ๋•Œ
แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-10-07 แ„‹แ…ฉแ„’แ…ฎ 12 03 00
  • ๋Œ€๊ธฐ ์ค‘์ผ ๋•Œ
แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-10-07 แ„‹แ…ฉแ„’แ…ฎ 12 03 22

๋ถ€์Šค ๋ฆฌ์ŠคํŠธ

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-10-07 แ„‹แ…ฉแ„’แ…ฎ 12 03 38

โœ… Check List

  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€?
  • ์ตœ์ข… ์ฝ”๋“œ๊ฐ€ ์—๋Ÿฌ ์—†์ด ์ž˜ ๋™์ž‘ํ•˜๋Š”๊ฐ€?

@dudtlstm dudtlstm added ๐Ÿฑ์˜์‹ ์ž‘์—… ์˜์‹  ์ž‘์—… ๐Ÿ› ๏ธFix ๋ฒ„๊ทธ ํ”ฝ์Šค labels Oct 7, 2024
@jiyoon607 jiyoon607 merged commit 8491fd9 into LINE-NOW:main Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿฑ์˜์‹ ์ž‘์—… ์˜์‹  ์ž‘์—… ๐Ÿ› ๏ธFix ๋ฒ„๊ทธ ํ”ฝ์Šค
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants