add appimage build target #398
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LIJI32
force-pushed
the
master
branch
4 times, most recently
from
4ebe973 to
0989ee2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple attempt at getting AppImages to work
feedback is definitely needed and I mainly wanted to get this out the door for now since this would allow for simple binary releases that target Linux.
This uses linuxdeploy which isn't package anywhere (that I am aware of) and is mainly distributed as an AppImage, so perhaps it would be better to put the tool into a variable that is definable when invoking make.
FreeDesktop/AppIcon/512x512.png has been symlinked to FreeDesktop/sameboy.png simply because the linuxdeploy needs the icon file and the icon variable in the desktop file to be the same.
the resource_path() function has been patched to check for the
APPDIRenvironment variable that is specified herehttps://docs.appimage.org/packaging-guide/environment-variables.html
If needed I can include a Github Actions workflow that builds an AppImage for releases