Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state machine #7

Merged
merged 11 commits into from
May 22, 2024
Merged

Add state machine #7

merged 11 commits into from
May 22, 2024

Conversation

survived
Copy link
Contributor

@survived survived commented May 14, 2024

State machine wraps an MPC protocol defined as async function and provides sync interface to carry it out

Blocked by #6

@survived survived changed the base branch from m to nostd May 14, 2024 11:33
@survived survived marked this pull request as ready for review May 15, 2024 08:53
@survived survived requested a review from a team as a code owner May 15, 2024 08:53
@survived survived requested a review from maurges May 15, 2024 08:53
Base automatically changed from nostd to m May 16, 2024 13:39
Comment on lines +90 to +92
let y = s.yielded;
s.yielded = false;
y
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std::mem::replace(&mut s.yielded, false). But it really doesn't matter, feel free to ignore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try this next time ;)

Copy link
Contributor

@maurges maurges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know what, I can't think about this for two more weeks, let's see if we get some real bugs in real usage

@survived survived merged commit 53fca7f into m May 22, 2024
9 checks passed
@survived survived deleted the state-machine branch May 22, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants