Apply multiscalar optimization #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
survived
commented
Apr 17, 2024
survived
commented
Jun 21, 2024
Comment on lines
+12
to
+18
| [patch.crates-io.cggmp21-keygen] | ||
| git = "https://github.com/dfnsco/cggmp21-private" | ||
| rev = "730e1217443eccac983d0177cab222decf07f139" | ||
|
|
||
| [patch.crates-io.key-share] | ||
| git = "https://github.com/dfnsco/cggmp21-private" | ||
| rev = "730e1217443eccac983d0177cab222decf07f139" |
survived
commented
Jun 21, 2024
Comment on lines
+11
to
+17
| [patch.crates-io.cggmp21-keygen] | ||
| git = "https://github.com/dfnsco/cggmp21-private" | ||
| rev = "730e1217443eccac983d0177cab222decf07f139" | ||
|
|
||
| [patch.crates-io.key-share] | ||
| git = "https://github.com/dfnsco/cggmp21-private" | ||
| rev = "730e1217443eccac983d0177cab222decf07f139" |
Signed-off-by: Denis Varlakov <[email protected]>
|
Looks good |
|
@maurges I would prefer merging this PR before |
|
I don't like to have to do it, but ok |
maurges
approved these changes
Jul 8, 2024
|
Me neither, but I'm blocked otherwise |
survived
added a commit
that referenced
this pull request
Jul 23, 2024
# This is the 1st commit message: Remove requirement that bitcoin key shares need to be normalized Signed-off-by: Denis Varlakov <[email protected]> # This is the commit message #2: Update docs Signed-off-by: Denis Varlakov <[email protected]> # This is the commit message #3: Update docs Signed-off-by: Denis Varlakov <[email protected]> # This is the commit message #4: Update README Signed-off-by: Denis Varlakov <[email protected]> # This is the commit message #5: First attempt to add HD wallets Signed-off-by: Denis Varlakov <[email protected]> # This is the commit message #6: Second attempt to implement HD wallets Signed-off-by: Denis Varlakov <[email protected]> # This is the commit message #7: The final attempt to implement HD wallets Signed-off-by: Denis Varlakov <[email protected]> # This is the commit message #8: Update deps Signed-off-by: Denis Varlakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.