Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit with grading #13

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Submit with grading #13

wants to merge 6 commits into from

Conversation

InesPessoa
Copy link
Contributor

No description provided.

@InesPessoa InesPessoa requested a review from buedaswag March 28, 2021 15:28
@InesPessoa InesPessoa linked an issue Mar 28, 2021 that may be closed by this pull request
@InesPessoa
Copy link
Contributor Author

@buedaswag Can we review this please, so we can include grading on this week SLUs?

@mariana-s-fernandes
Copy link

mariana-s-fernandes commented Apr 1, 2021

Hi @InesPessoa , there is small typo in Exercises notebook "sumit" instead of "submit". It could propagate to all SLUs when the instructors are copying the cells.

I think that the text in the notebook also needs to be reviewed (please include the emojis again, I don't have the code for it now):

Congratulations, you've completed SLU00! Let's grade it and send some feedback to the instructors.

Before moving on, please run and save this notebook. This step is needed in order to ensure that the notebook is graded based on the most recent version of your answers. Then, move onto the next step.

To submit your work, get your slack id and assign it to the slack_id(https://moshfeu.medium.com/how-to-find-my-member-id-in-slack-workspace-d4bba942e38c) variable in the cell below. Example:


<img src='assets/submit.png' alt='Finder' width="75%" />

**Cell 1** markdown, read-only
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

despite this info also being in the in the example notebook, i want to keep it here because instructors will quickly be able to know exactly what to put in their exercise notebooks based on this info

}
},
"source": [
"# Sumit your work!"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here

@mariana-s-fernandes
Copy link

mariana-s-fernandes commented Apr 1, 2021

(sorry that I've just invaded this review 😁 ) I noticed that the image in the README should also be updated to be consistent with the new code
image

@mariana-s-fernandes
Copy link

Is it still possible to fix the typo in the folder name instructores_example to instructors_example?

@cimendes
Copy link
Member

cimendes commented Apr 5, 2021

Any idea of when this will be accepted? I've materials for week02 and i'll need to update them if this is merged.

@buedaswag
Copy link
Collaborator

@cimendes thanks for keeping an eye for this! :D
dont count on it for week 02 (if it does get merged before the release we'll just add any changes necessary to the LUs)

@InesPessoa
Copy link
Contributor Author

@cimendes I will be working on this during this week, but as @buedaswag said, don't count with this for week 2. We will keep you and @mariana-s-fernandes in touch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract grade from the exercises notebook
4 participants