Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-commit clang format #1464

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Auto-commit clang format #1464

merged 1 commit into from
Sep 18, 2024

Conversation

tvami
Copy link
Member

@tvami tvami commented Sep 17, 2024 •
edited
Loading

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

Resolves #1457

Check List

  • I successfully compiled ldmx-sw with my developments
  • I ran my developments and the following shows that they are successful.

The test happened on GitHub:

  • If there is a change to apply, the bot indeed did it
  • If no change to apply, it didnt do anything

@tvami
Copy link
Member Author

tvami commented Sep 17, 2024

Wow look at that!

Screenshot 2024-09-17 at 13 33 50

@tvami tvami force-pushed the iss1457-auto-commit-clang-format branch from 4657f07 to 2448943 Compare September 17, 2024 20:44
@tvami
Copy link
Member Author

tvami commented Sep 17, 2024

1 cancelled and 1 successful checks

I cancelled the basic test since it's not relevant to the change, the other one tests everything we need

tomeichlersmith
tomeichlersmith reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@tomeichlersmith tomeichlersmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a cosmetic change to make the name appearing the GitHub messages a bit easier to parse. (GitHub uses the / character for separating the workflow name from other details.)

.github/workflows/format-check.yml Outdated Show resolved Hide resolved
@tvami tvami force-pushed the iss1457-auto-commit-clang-format branch from 2448943 to 7ee708a Compare September 17, 2024 21:25
@tvami tvami mentioned this pull request Sep 18, 2024
Merged
2 tasks
@tvami tvami merged commit 8e250fc into trunk Sep 18, 2024
2 checks passed
@tvami tvami deleted the iss1457-auto-commit-clang-format branch September 18, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyi211 danyi211 danyi211 approved these changes

@tomeichlersmith tomeichlersmith tomeichlersmith approved these changes

@bryngemark bryngemark Awaiting requested review from bryngemark

@bloodyyugo bloodyyugo Awaiting requested review from bloodyyugo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto-commit clang format
3 participants
@tvami @tomeichlersmith @danyi211