-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Part 3 of static analysis: clang-tidy #1460
Conversation
Tests ran fine https://github.com/LDMX-Software/ldmx-sw/actions/runs/10894469361 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C++ changes look good, my comments are mainly focused on passing arguments to recipes within the justfile simply to avoid the recursive call to the program itself and maybe moving default build settings into the CMakeLists.txt.
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
Resolves #1176
Check List
I killed all the warning.
is now nice and clean.