Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 3 of static analysis: clang-tidy #1460

Merged
merged 7 commits into from
Sep 17, 2024
Merged

Part 3 of static analysis: clang-tidy #1460

merged 7 commits into from
Sep 17, 2024

Conversation

tvami
Copy link
Member

@tvami tvami commented Sep 17, 2024

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

Resolves #1176

Check List

  • I successfully compiled ldmx-sw with my developments
  • I ran my developments and the following shows that they are successful.

I killed all the warning.

rm -rf build
just configure -DADDITIONAL_WARNINGS=ON  -DENABLE_CLANG_TIDY=ON  -DENABLE_LTO=ON  -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_C_COMPILER=clang
just build
// And switch back to a build with GCC
rm -rf build 
just configure -DADDITIONAL_WARNINGS=ON  -DENABLE_CLANG_TIDY=ON  -DENABLE_LTO=ON 
just build

is now nice and clean.

@tvami tvami added cleanup memory leak fix Tags issues and PRs that fix memory leaks. labels Sep 17, 2024
@tvami
Copy link
Member Author

tvami commented Sep 17, 2024

Tests ran fine https://github.com/LDMX-Software/ldmx-sw/actions/runs/10894469361
(except for the ecal pn, but that's broken bc of the tracking change, I'll fix it with #1459 tomorrow)

Copy link
Member

@tomeichlersmith tomeichlersmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ changes look good, my comments are mainly focused on passing arguments to recipes within the justfile simply to avoid the recursive call to the program itself and maybe moving default build settings into the CMakeLists.txt.

CMakeLists.txt Show resolved Hide resolved
Framework/src/Framework/Event.cxx Outdated Show resolved Hide resolved
justfile Outdated Show resolved Hide resolved
justfile Outdated Show resolved Hide resolved
justfile Show resolved Hide resolved
@tvami tvami merged commit 23fc3e3 into trunk Sep 17, 2024
2 checks passed
@tvami tvami deleted the iss1176-part3-clang-tidy branch September 17, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup memory leak fix Tags issues and PRs that fix memory leaks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static analysis meta-issue
3 participants