Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UB in DetectorIDTest.cxx #1436

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

tvami
Copy link
Member

@tvami tvami commented Sep 5, 2024

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

This is the last bit of #1166

Check List

  • I successfully compiled ldmx-sw with my developments
  • I ran my developments and the following shows that they are successful.

I ran

denv cmake -B build -S . -DENABLE_SANITIZER_UNDEFINED_BEHAVIOR=ON
denv cmake --build build --target install -- -j$(nproc)
denv build/run_test [DetDescr]

which shows the problem before this fix, now it's gone.

[vamitamas@pod-login1 ldmx-sw]$ denv build/run_test [DetDescr]
Filters: [DetDescr]
Randomness seeded to: 1942624396
===============================================================================
All tests passed (92 assertions in 1 test case)


=================================================================

@tomeichlersmith tomeichlersmith merged commit 6ea297b into trunk Sep 5, 2024
4 of 10 checks passed
@tomeichlersmith tomeichlersmith deleted the iss1166-specialid-test branch September 5, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants