Introduce EcalPreselectionSkimmer #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvami
force-pushed
the
iss1387-presel-skim
branch
from
4fbc09d to
3324c07
Compare
tomeichlersmith
requested changes
Aug 13, 2024
tomeichlersmith
approved these changes
Aug 14, 2024
danyi211
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
Resolves #1387
Check List
I used the validation ecal pn config to produce 10k events. Then I run
Recon/test/ecal_preselection_skim.pyon it. The current settings lead that 10k to 53 events, and looking at the distributions indeed they are cut off at the values set in the config. I made everything configurable and kept the defaults so high that it doesnt do anything in default.