Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework on v1.4.2 #1257

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Framework on v1.4.2 #1257

merged 1 commit into from
Jan 30, 2024

Conversation

tomeichlersmith
Copy link
Member

See the patch PR in Framework LDMX-Software/Framework#93 for solution. The bug was originally noticed when running the PR Validation tests on #1255 and #1256 after updating the golden histograms with the buggy framework.

In short: when running with a processor that calls getHistoDirectory() during processing, the run tree ends up in the histogram file rather than the event file. This is an easy fix and is only a problem for configs that use the SimObjects DQM processor (the only processor that I know of that dynamically calls getHistoDirectory() during processing).

@tomeichlersmith
Copy link
Member Author

The basic tests failed because they weren't able to wget the CSV file from UMN for testing the conditions loading 🙄 opening the PR to see if we can get past that test and look at the output of the validation sample configs to make sure this patch is running them like normal.

@tomeichlersmith
Copy link
Member Author

The validations are failing at the same point as #1255 and #1256 . Re-running the hcal validation sample locally, I can confirm that the run tree is in the event file and not the hist file.

[ldmx] tom@appa:~/code/ldmx/ldmx-sw/.github/validation_samples/hcal$ ldmx rootls {gold,hist,events}.root:*
WARNING: Several versions of 'LDMX_Events' are present in 'events.root'. Only the most recent will be considered.
events.root :
  LDMX_Events  LDMX_Run
gold.root :
  hcal_dqm_back :
    hcal_dqm_back_along_x          hcal_dqm_back_along_y           hcal_dqm_back_along_z           hcal_dqm_back_energy              hcal_dqm_back_hit_multiplicity      hcal_dqm_back_hit_time                   hcal_dqm_back_hit_z
    hcal_dqm_back_layer            hcal_dqm_back_layer:strip       hcal_dqm_back_max_pe            hcal_dqm_back_max_pe_time         hcal_dqm_back_noise                 hcal_dqm_back_pe                         hcal_dqm_back_sim_along_x
    hcal_dqm_back_sim_along_y      hcal_dqm_back_sim_along_z       hcal_dqm_back_sim_energy        hcal_dqm_back_sim_energy_per_bar  hcal_dqm_back_sim_hit_multiplicity  hcal_dqm_back_sim_hit_time               hcal_dqm_back_sim_layer
    hcal_dqm_back_sim_layer:strip  hcal_dqm_back_sim_num_bars_hit  hcal_dqm_back_sim_total_energy  hcal_dqm_back_total_energy        hcal_dqm_back_total_pe              hcal_dqm_back_vetoable_hit_multiplicity
  sim_dqm :
    LDMX_Run                               LDMX_Run                         sim_dqm_EcalSimHits.edep              sim_dqm_EcalSimHits.incidents          sim_dqm_EcalSimHits.n_contribs     sim_dqm_EcalSimHits.pdg
    sim_dqm_EcalSimHits.time               sim_dqm_EcalSimHits.tracks       sim_dqm_EcalSimHits.x                 sim_dqm_EcalSimHits.y                  sim_dqm_EcalSimHits.z              sim_dqm_HcalSimHits.edep
    sim_dqm_HcalSimHits.incidents          sim_dqm_HcalSimHits.n_contribs   sim_dqm_HcalSimHits.pdg               sim_dqm_HcalSimHits.time               sim_dqm_HcalSimHits.tracks         sim_dqm_HcalSimHits.x
    sim_dqm_HcalSimHits.y                  sim_dqm_HcalSimHits.z            sim_dqm_pn_child.children             sim_dqm_pn_child.E                     sim_dqm_pn_child.parent            sim_dqm_pn_child.pdg
    sim_dqm_pn_child.px                    sim_dqm_pn_child.py              sim_dqm_pn_child.pz                   sim_dqm_pn_child.time                  sim_dqm_pn_child.track_id          sim_dqm_pn_child.x
    sim_dqm_pn_child.y                     sim_dqm_pn_child.z               sim_dqm_RecoilSimHits.edep            sim_dqm_RecoilSimHits.particle_E       sim_dqm_RecoilSimHits.particle_px  sim_dqm_RecoilSimHits.particle_py
    sim_dqm_RecoilSimHits.particle_pz      sim_dqm_RecoilSimHits.pdg        sim_dqm_RecoilSimHits.time            sim_dqm_RecoilSimHits.track            sim_dqm_RecoilSimHits.x            sim_dqm_RecoilSimHits.y
    sim_dqm_RecoilSimHits.z                sim_dqm_SimParticles.children    sim_dqm_SimParticles.E                sim_dqm_SimParticles.parent            sim_dqm_SimParticles.pdg           sim_dqm_SimParticles.process
    sim_dqm_SimParticles.px                sim_dqm_SimParticles.py          sim_dqm_SimParticles.pz               sim_dqm_SimParticles.time              sim_dqm_SimParticles.track_id      sim_dqm_SimParticles.x
    sim_dqm_SimParticles.y                 sim_dqm_SimParticles.z           sim_dqm_TaggerSimHits.edep            sim_dqm_TaggerSimHits.particle_E       sim_dqm_TaggerSimHits.particle_px  sim_dqm_TaggerSimHits.particle_py
    sim_dqm_TaggerSimHits.particle_pz      sim_dqm_TaggerSimHits.pdg        sim_dqm_TaggerSimHits.time            sim_dqm_TaggerSimHits.track            sim_dqm_TaggerSimHits.x            sim_dqm_TaggerSimHits.y
    sim_dqm_TaggerSimHits.z                sim_dqm_TargetSimHits.edep       sim_dqm_TargetSimHits.incidents       sim_dqm_TargetSimHits.n_contribs       sim_dqm_TargetSimHits.pdg          sim_dqm_TargetSimHits.time
    sim_dqm_TargetSimHits.tracks           sim_dqm_TargetSimHits.x          sim_dqm_TargetSimHits.y               sim_dqm_TargetSimHits.z                sim_dqm_TriggerPad1SimHits.edep    sim_dqm_TriggerPad1SimHits.incidents
    sim_dqm_TriggerPad1SimHits.n_contribs  sim_dqm_TriggerPad1SimHits.pdg   sim_dqm_TriggerPad1SimHits.time       sim_dqm_TriggerPad1SimHits.tracks      sim_dqm_TriggerPad1SimHits.x       sim_dqm_TriggerPad1SimHits.y
    sim_dqm_TriggerPad1SimHits.z           sim_dqm_TriggerPad2SimHits.edep  sim_dqm_TriggerPad2SimHits.incidents  sim_dqm_TriggerPad2SimHits.n_contribs  sim_dqm_TriggerPad2SimHits.pdg     sim_dqm_TriggerPad2SimHits.time
    sim_dqm_TriggerPad2SimHits.tracks      sim_dqm_TriggerPad2SimHits.x     sim_dqm_TriggerPad2SimHits.y          sim_dqm_TriggerPad2SimHits.z           sim_dqm_TriggerPad3SimHits.edep    sim_dqm_TriggerPad3SimHits.incidents
    sim_dqm_TriggerPad3SimHits.n_contribs  sim_dqm_TriggerPad3SimHits.pdg   sim_dqm_TriggerPad3SimHits.time       sim_dqm_TriggerPad3SimHits.tracks      sim_dqm_TriggerPad3SimHits.x       sim_dqm_TriggerPad3SimHits.y
    sim_dqm_TriggerPad3SimHits.z
hist.root :
  hcal_dqm_back :
    hcal_dqm_back_along_x          hcal_dqm_back_along_y           hcal_dqm_back_along_z           hcal_dqm_back_energy              hcal_dqm_back_hit_multiplicity      hcal_dqm_back_hit_time                   hcal_dqm_back_hit_z
    hcal_dqm_back_layer            hcal_dqm_back_layer:strip       hcal_dqm_back_max_pe            hcal_dqm_back_max_pe_time         hcal_dqm_back_noise                 hcal_dqm_back_pe                         hcal_dqm_back_sim_along_x
    hcal_dqm_back_sim_along_y      hcal_dqm_back_sim_along_z       hcal_dqm_back_sim_energy        hcal_dqm_back_sim_energy_per_bar  hcal_dqm_back_sim_hit_multiplicity  hcal_dqm_back_sim_hit_time               hcal_dqm_back_sim_layer
    hcal_dqm_back_sim_layer:strip  hcal_dqm_back_sim_num_bars_hit  hcal_dqm_back_sim_total_energy  hcal_dqm_back_total_energy        hcal_dqm_back_total_pe              hcal_dqm_back_vetoable_hit_multiplicity
  sim_dqm :
    sim_dqm_EcalSimHits.edep              sim_dqm_EcalSimHits.incidents          sim_dqm_EcalSimHits.n_contribs     sim_dqm_EcalSimHits.pdg               sim_dqm_EcalSimHits.time               sim_dqm_EcalSimHits.tracks
    sim_dqm_EcalSimHits.x                 sim_dqm_EcalSimHits.y                  sim_dqm_EcalSimHits.z              sim_dqm_HcalSimHits.edep              sim_dqm_HcalSimHits.incidents          sim_dqm_HcalSimHits.n_contribs
    sim_dqm_HcalSimHits.pdg               sim_dqm_HcalSimHits.time               sim_dqm_HcalSimHits.tracks         sim_dqm_HcalSimHits.x                 sim_dqm_HcalSimHits.y                  sim_dqm_HcalSimHits.z
    sim_dqm_pn_child.children             sim_dqm_pn_child.E                     sim_dqm_pn_child.parent            sim_dqm_pn_child.pdg                  sim_dqm_pn_child.px                    sim_dqm_pn_child.py
    sim_dqm_pn_child.pz                   sim_dqm_pn_child.time                  sim_dqm_pn_child.track_id          sim_dqm_pn_child.x                    sim_dqm_pn_child.y                     sim_dqm_pn_child.z
    sim_dqm_RecoilSimHits.edep            sim_dqm_RecoilSimHits.particle_E       sim_dqm_RecoilSimHits.particle_px  sim_dqm_RecoilSimHits.particle_py     sim_dqm_RecoilSimHits.particle_pz      sim_dqm_RecoilSimHits.pdg
    sim_dqm_RecoilSimHits.time            sim_dqm_RecoilSimHits.track            sim_dqm_RecoilSimHits.x            sim_dqm_RecoilSimHits.y               sim_dqm_RecoilSimHits.z                sim_dqm_SimParticles.children
    sim_dqm_SimParticles.E                sim_dqm_SimParticles.parent            sim_dqm_SimParticles.pdg           sim_dqm_SimParticles.process          sim_dqm_SimParticles.px                sim_dqm_SimParticles.py
    sim_dqm_SimParticles.pz               sim_dqm_SimParticles.time              sim_dqm_SimParticles.track_id      sim_dqm_SimParticles.x                sim_dqm_SimParticles.y                 sim_dqm_SimParticles.z
    sim_dqm_TaggerSimHits.edep            sim_dqm_TaggerSimHits.particle_E       sim_dqm_TaggerSimHits.particle_px  sim_dqm_TaggerSimHits.particle_py     sim_dqm_TaggerSimHits.particle_pz      sim_dqm_TaggerSimHits.pdg
    sim_dqm_TaggerSimHits.time            sim_dqm_TaggerSimHits.track            sim_dqm_TaggerSimHits.x            sim_dqm_TaggerSimHits.y               sim_dqm_TaggerSimHits.z                sim_dqm_TargetSimHits.edep
    sim_dqm_TargetSimHits.incidents       sim_dqm_TargetSimHits.n_contribs       sim_dqm_TargetSimHits.pdg          sim_dqm_TargetSimHits.time            sim_dqm_TargetSimHits.tracks           sim_dqm_TargetSimHits.x
    sim_dqm_TargetSimHits.y               sim_dqm_TargetSimHits.z                sim_dqm_TriggerPad1SimHits.edep    sim_dqm_TriggerPad1SimHits.incidents  sim_dqm_TriggerPad1SimHits.n_contribs  sim_dqm_TriggerPad1SimHits.pdg
    sim_dqm_TriggerPad1SimHits.time       sim_dqm_TriggerPad1SimHits.tracks      sim_dqm_TriggerPad1SimHits.x       sim_dqm_TriggerPad1SimHits.y          sim_dqm_TriggerPad1SimHits.z           sim_dqm_TriggerPad2SimHits.edep
    sim_dqm_TriggerPad2SimHits.incidents  sim_dqm_TriggerPad2SimHits.n_contribs  sim_dqm_TriggerPad2SimHits.pdg     sim_dqm_TriggerPad2SimHits.time       sim_dqm_TriggerPad2SimHits.tracks      sim_dqm_TriggerPad2SimHits.x
    sim_dqm_TriggerPad2SimHits.y          sim_dqm_TriggerPad2SimHits.z           sim_dqm_TriggerPad3SimHits.edep    sim_dqm_TriggerPad3SimHits.incidents  sim_dqm_TriggerPad3SimHits.n_contribs  sim_dqm_TriggerPad3SimHits.pdg
    sim_dqm_TriggerPad3SimHits.time       sim_dqm_TriggerPad3SimHits.tracks      sim_dqm_TriggerPad3SimHits.x       sim_dqm_TriggerPad3SimHits.y          sim_dqm_TriggerPad3SimHits.z

@tomeichlersmith tomeichlersmith marked this pull request as ready for review January 30, 2024 19:22
@tomeichlersmith tomeichlersmith merged commit 3bfe38d into trunk Jan 30, 2024
4 of 8 checks passed
@tomeichlersmith tomeichlersmith deleted the patch-run-header-write-location branch January 30, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tomeichlersmith