add notes on using libDetDescr with numpy #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I figured this out since I was sick of doing the bit shifting myself. It is not as performant as the bit shifting but it works pretty well and avoids copying around magic numbers.
the linked numpy doc goes into more detail on how this is more performant than a raw python `for` loop but not as performant as writing a complete ufunc ourselves.
tomeichlersmith
force-pushed
the
notes-on-numpy
branch
from
6ddcdbb to
d84ba68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured this out since I was sick of doing the bit shifting myself. It is not as performant as the bit shifting but it works pretty well and avoids copying around magic numbers.