1220 filter and handle missing entries in the validation module #1223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am updating ldmx-sw, here are the details.
I've added two new command line parameters for the validation module, one which lets you specify exactly which files you want to compare (as opposed to all files in the input data directory). You can either specify the name of a file in the input directory or give the entire path to the file. The other parameter lets you filter the list of root-files (a use-case for this in my case would be filtering on the number of events in a pile of files).
Also added an exception handling step in Differ to handle missing histograms gracefully.
Example usage:
Assuming you have three files in the hists/ folder
Running
Would only plot the two ecal files with 10k events
Running
Would use the three files including "ecal" in the name
etc
What are the issues that this addresses?
Hint: Use the phrase 'This resolves #< issue number >' so that they are linked automatically.
This resolves #1220
Check List
I successfully compiled ldmx-sw with my developments
I ran my developments and the following shows that they are successful.
Tested both the new parameters and handling of missing histograms. Worked like a charm :)
I attached any sub-module related changes to this PR.
N/A
Related Sub-Module PRs
N/A